Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] Ensure that source maps can be used to debug errors during record and playback #6298

Closed
sadasant opened this issue Nov 21, 2019 · 3 comments · Fixed by #6430
Closed

[Recorder] Ensure that source maps can be used to debug errors during record and playback #6298

sadasant opened this issue Nov 21, 2019 · 3 comments · Fixed by #6430
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library.

Comments

@sadasant
Copy link
Contributor

Currently, if there's any error during record or playback, the trace of the error only routes through built files, making it almost impossible to debug.
@sadasant sadasant added the Client This issue points to a problem in the data-plane of the library. label Nov 21, 2019
@sadasant sadasant self-assigned this Nov 21, 2019
@HarshaNalluru HarshaNalluru mentioned this issue Nov 21, 2019
Closed
62 tasks
This was referenced Dec 4, 2019
Closed
Closed
@sadasant
Copy link
Contributor Author

sadasant commented Dec 5, 2019

Made this other issue to track the browser fix: #6429

Our current solution is to move nyc outside of the integration tests. The current problem is that nyc/istanbul is not mapping the sourcemaps correctly. Another plus side is that reporting slows tests considerably.

sadasant added a commit to sadasant/azure-sdk-for-js that referenced this issue Dec 5, 2019
@sadasant
[Recorder] Separating nyc from the integration tests for Node
a4527c3 
nyc is obscuring Mocha's stack traces. It's unable to follow through the
references. This is the fastest fix, and this will incidentally make our
Node tests faster.

Fixes Azure#6298
@sadasant sadasant mentioned this issue Dec 5, 2019
Merged
jeremymeng pushed a commit that referenced this issue Dec 18, 2019
@sadasant @jeremymeng
Separating nyc from the integration tests for Node (#6430)
6c8595e 
nyc is obscuring Mocha's stack traces. It's unable to follow through the
references. This is the fastest fix, and this will incidentally make our
Node tests faster.

Fixes #6298
@ramya-rao-a
Copy link
Contributor

The problem described here is for sourcemap issues caused by nyc during record & playback.

For playback, we use the npm script unit which doesnt use nyc
For record, we use the npm script integration locally only.

So, the problem seems to be only in the case of recording the tests, is that right @sadasant?

@ramya-rao-a
Copy link
Contributor

Ah, looks like the npm script for unit is calling the npm script for integration which in turn was using nyc

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separating nyc from the integration tests for Node sadasant/azure-sdk-for-js
2 participants
@sadasant @ramya-rao-a