-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev-time Credential Experience for Azure.Identity #6769
Comments
Moving this to the September milestone for tracking in the next Identity wave |
Question:
Was this done here? https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/src/credentials/defaultAzureCredential.ts#L42-L46 Please let me know if I'm missing something 🙂 |
@sadasant - it was decided to not have MICred read the env var. It's done via DAC. |
@jonathandturner Please add a link to the MSAL issue that we are now blocked on |
I believe we won't be adding support for writing back to the SharedTokenCache this month. Moving to March. |
These two items:
Are fixed by this PR: #14064 |
The PR is merged so I'm making those two items as done. |
For this last item:
I'll ask for help to @catalinaperalta to see if she can help me determine how far we're off of the mark. I can do the alignment afterwards. |
@sadasant I took a look at Chained Token Credential and you are missing the credential information in the success logs. On line:
This log message should include the credential that succeeded or you can add an additional log message that states which credential was used. In Go the message would look something like this:
That's basically what you need to satisfy the logging requirement for DAC and Chained Token Credential. |
@catalinaperalta Thank you so much! I'll make a PR |
Fixes to the ChainedTokenCredential logging. It now documents what credential succeeds. Also added a test. Fixes #6769
Fixes to the ChainedTokenCredential logging. It now documents what credential succeeds. Also added a test. Fixes Azure#6769
Tracking issue for feature work specific to Developer-time Azure.Identity Credential Experience
Bring back file based auth for Management Plane: https://docs.microsoft.com/en-us/dotnet/azure/dotnet-sdk-azure-authenticate?view=azure-dotnet#mgmt-auth AZURE_AUTH_LOCATION (see SupportAZURE_AUTH_LOCATION
azure-sdk-for-net#9312) (@ellismg driving design requirements)Add Support for writing back to the SharedTokenCache (@schaabs driving design requirements) (blocked on [Identity] Azure SDK credential built on msal-node #9778)
Add Linux and Mac SharedTokenCache Support (@jianghaolu driving design requirements) (blocked on [Identity] Azure SDK credential built on msal-node #9778)
Improve DefaultAzureCredential/ChainedTokenCredential - e.g., tell me what Credential I'm using for dev debug scenarios (accomplied via logging change @catalinaperalta driving design requirements)
Have ManagedIdentityCredential utilize the AZURE_CLIENT_ID environment variable. To allow user assigned identities to utilize DefaultAzureCredential (@jongio driving implementation with vendor team)
Have TokenCredentialOptions utilize AZURE_AUTHORITY_HOST environment variable. To allow other clouds to use DefaultAzureCredential. (@jongio driving implementation with vendor team)
CliCredentials / Better support for dev creds: CLI, PSH, VS, VS CODE, VS ONLINE, CLOUD SHELL
The text was updated successfully, but these errors were encountered: