Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev-time Credential Experience for Azure.Identity #6769

Closed
5 of 7 tasks
joshfree opened this issue Jan 3, 2020 · 10 comments · Fixed by #14847
Closed
5 of 7 tasks

Dev-time Credential Experience for Azure.Identity #6769

joshfree opened this issue Jan 3, 2020 · 10 comments · Fixed by #14847
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. Epic
Milestone

Comments

@joshfree
Copy link
Member

joshfree commented Jan 3, 2020

Tracking issue for feature work specific to Developer-time Azure.Identity Credential Experience

@joshfree
Copy link
Member Author

Moving this to the September milestone for tracking in the next Identity wave

@joshfree joshfree changed the title Create an Amazing Dev-time Credential Experience for Azure.Identity Dev-time Credential Experience for Azure.Identity Jul 23, 2020
@sadasant
Copy link
Contributor

Question:

Have ManagedIdentityCredential utilize the AZURE_CLIENT_ID environment variable. To allow user assigned identities to utilize DefaultAzureCredential (@jongio driving implementation with vendor team)

Was this done here? https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/src/credentials/defaultAzureCredential.ts#L42-L46

Please let me know if I'm missing something 🙂

@jongio
Copy link
Member

jongio commented Aug 3, 2020

@sadasant - it was decided to not have MICred read the env var. It's done via DAC.

@ramya-rao-a
Copy link
Contributor

@jonathandturner Please add a link to the MSAL issue that we are now blocked on

@sadasant
Copy link
Contributor

I believe we won't be adding support for writing back to the SharedTokenCache this month. Moving to March.

@ramya-rao-a ramya-rao-a assigned sadasant and unassigned sophiajt Jan 31, 2021
@sadasant sadasant modified the milestones: [2021] March, [2021] April Feb 23, 2021
@sadasant
Copy link
Contributor

sadasant commented Mar 15, 2021

These two items:

Are fixed by this PR: #14064

@sadasant
Copy link
Contributor

The PR is merged so I'm making those two items as done.

@sadasant sadasant removed this from the [2021] April milestone Mar 31, 2021
@sadasant sadasant added this to the [2021] May milestone Mar 31, 2021
@sadasant
Copy link
Contributor

For this last item:

Improve DefaultAzureCredential/ChainedTokenCredential - e.g., tell me what Credential I'm using for dev debug scenarios (accomplied via logging change @catalinaperalta driving design requirements)

I'll ask for help to @catalinaperalta to see if she can help me determine how far we're off of the mark. I can do the alignment afterwards.

@catalinaperalta
Copy link
Member

@sadasant I took a look at Chained Token Credential and you are missing the credential information in the success logs. On line:

logger.getToken.info(formatSuccess(scopes));

This log message should include the credential that succeeded or you can add an additional log message that states which credential was used. In Go the message would look something like this:

Azure Identity => GetToken() result for <CREDENTIAL NAME HERE>: SUCCESS

That's basically what you need to satisfy the logging requirement for DAC and Chained Token Credential.

@sadasant
Copy link
Contributor

@catalinaperalta Thank you so much! I'll make a PR

@ghost ghost closed this as completed in #14847 Apr 13, 2021
ghost pushed a commit that referenced this issue Apr 13, 2021
Fixes to the ChainedTokenCredential logging. It now documents what credential succeeds.

Also added a test.

Fixes #6769
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this issue Apr 26, 2021
Fixes to the ChainedTokenCredential logging. It now documents what credential succeeds.

Also added a test.

Fixes Azure#6769
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. Epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants