-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev dependency @rollup/plugin-commonjs #9066
Comments
Is there an example of the output from the build break? |
|
We will also need the circular dependency fixes from this PR which were never merged: These are needed for |
For more reference, ongoing investigation in the draft PR #9074 |
Currently blocked on an upstream bug in @rollup/plugin-commonjs: rollup/plugins#743 Migrating to rollup 2 and the newer versions of plugin-commonjs will ease the transition to the shared rollup configuration, so this is related to that as well. |
Closing in favor of bot-auto-filed issue #19156 |
Dependency
@rollup/plugin-commonjs
was pinned to11.0.2
in #9045, since11.1.0
causes build breaks in our repo. The dependency should be updated to either11.1.0
or the latest (currently12.0.0
).https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md
CC: @HarshaNalluru
The text was updated successfully, but these errors were encountered: