Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Update dependencies to latest major version #9248

Closed
mikeharder opened this issue Jun 3, 2020 · 1 comment
Closed

[EngSys] Update dependencies to latest major version #9248

mikeharder opened this issue Jun 3, 2020 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@mikeharder
Copy link
Member

mikeharder commented Jun 3, 2020

Process

  1. rush unlink& git clean -xdf
  2. Edit common\config\rush\common-versions.json and set implicitlyPreferredVersions=true
  3. Edit rush.json and set strictPeerDependencies=false
  4. rush update --full
  5. Collect list of dependencies with newer major versions
  6. Revert changes to common-versions.json and rush.json
  7. Create one PR for each dependency which needs a major version update

Test dependencies not supporting Node 8

The following dependencies are used during tests and have dropped support for Node 8, but still seem to work when running tests on Node 8.

  • cross-env@7.0.0
  • nock@12.0.0
  • sinon@9.0.0

6/16/20

  • downlevel-dts 0.4.0 (0.5.0 is available)
  • keytar 5.6.0 (6.0.1 is available)
  • mocha-junit-reporter 1.23.3 (2.0.0 is available)
  • puppeteer 3.3.0 (4.0.0 is available)
  • rollup-plugin-terser 5.3.0 (6.1.0 is available)

6/2/20

Pending Approval

Pending Validation

Requires Code Changes

Blocked

  • @types/node 8.10.61 (14.0.4 is available)
    • Our packages still support Node 8. Should this be updated or not?
  • @azure/event-hubs 2.1.4 (5.2.0 is available), @azure/ms-rest-nodeauth 0.9.3 (3.0.3 is available)
    • Still used by eventhub/event-processor-host and/or eventhub/testhub
  • @opentelemetry/api 0.6.1 (0.8.1 is available)
    • Waiting for new features we want or another reason to re-release tracing
  • assert 1.5.0 (2.0.0 is available)
    • Requires shimming process, but still fails with errors.codes is undefined.
  • execa 3.4.0 (4.0.1 is available)
  • karma 4.4.1 (5.0.9 is available), @types/karma 4.4.2 (5.0.0 is available), karma-mocha 1.3.0 (2.0.1 is available)
  • query-string 5.1.1 (6.12.1 is available), @types/query-string 6.2.0 (6.3.0 is available)
  • rollup-plugin-sourcemaps 0.4.2 (0.6.2 is available)
    • rollup-plugin-sourcemaps@0.6.2 requires a peer of @types/node@>=10.0.0 but version 8.10.61 was installed
  • tslint 5.20.1 (6.1.2 is available)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2020
@mikeharder mikeharder added the EngSys This issue is impacting the engineering system. label Jun 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2020
@mikeharder mikeharder added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2020
@mikeharder mikeharder self-assigned this Jun 3, 2020
@jeremymeng jeremymeng assigned jeremymeng and unassigned mikeharder Aug 23, 2021
@jeremymeng jeremymeng reopened this Aug 23, 2021
@jeremymeng jeremymeng added this to the [2021] December milestone Aug 24, 2021
@jeremymeng
Copy link
Member

Closing as we already have an Epic to track engsys improvements #15971. I will create and add issues to that epic for new libs that have major version updates available.

@jeremymeng jeremymeng removed the Epic label Aug 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants