-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Rollback query-string package to version 5 #4156
[Storage] Rollback query-string package to version 5 #4156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! But CI tests failed. it relates to Rush update that other packages depend on query-string v6. You may need to sync package.json of other packages to the same ersion.
The shrinkwrap file is missing the following dependencies: | |
---|---|
"@types/query-string" (6.2.0) required by "@azure/storage-blob" | |
"query-string" (^5.0.0) required by "@azure/storage-blob" | |
"@types/query-string" (6.2.0) required by "@azure/storage-file" | |
"query-string" (^5.0.0) required by "@azure/storage-file" | |
"@types/query-string" (6.2.0) required by "@azure/storage-queue" | |
"query-string" (^5.0.0) required by "@azure/storage-queue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to update @types/query-string version?
I will push the updated pnpm-lock file. |
More info In order to use This fixes the IE issue temporarily. |
query-string package uses arrow functions starting from version 6.
To add the support for IE, we are moving to an older version of query-string(version 5).
Quoting - https://github.com/sindresorhus/query-string/releases/tag/v6.0.0