Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] Make eslint step mandatory and revert tslint #5431

Closed
HarshaNalluru opened this issue Oct 7, 2019 · 4 comments · Fixed by #14018
Closed

[Cosmos] Make eslint step mandatory and revert tslint #5431

HarshaNalluru opened this issue Oct 7, 2019 · 4 comments · Fixed by #14018
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos

Comments

@HarshaNalluru
Copy link
Member

PR #5429 temporarily enables tslint as part of the build step.
The changes from that PR have to be reverted once the eslint step is made mandatory.

/cc - @KarishmaGhiya @ramya-rao-a @willmtemple

@mikeharder
Copy link
Member

@HarshaNalluru: Will tslint be removed from the cosmos dev dependencies when this issue is fixed? cosmos is the only package in our repo still using tslint.

@HarshaNalluru
Copy link
Member Author

@mikeharder, yes.
We should probably make it a priority to fix the eslint errors in all the packages and make the step mandatory in the CI.

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. eslint plugin and removed EngSys This issue is impacting the engineering system. labels Jul 28, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jul 28, 2020
@deyaaeldeen
Copy link
Member

I think this can be closed now since we no longer use tslint and eslint is run as part of the analyze step in CI.

@ramya-rao-a
Copy link
Contributor

@deyaaeldeen This was needed to ensure we remove the tslint call in the build step after #10776 is done. We can close this if we include the above step in #10776 itself

@deyaaeldeen deyaaeldeen reopened this Nov 17, 2020
@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants