Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint errors in cosmos package #10776

Closed
praveenkuttappan opened this issue Aug 23, 2020 · 0 comments · Fixed by #13039
Closed

Fix ESLint errors in cosmos package #10776

praveenkuttappan opened this issue Aug 23, 2020 · 0 comments · Fixed by #13039
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Milestone

Comments

@praveenkuttappan
Copy link
Member

praveenkuttappan commented Aug 23, 2020

Fix lint errors found in cosmos packages by ESLint. Following are the steps to run ESLint for cosmos packages and reproduce this issue.

  1. Set up your dev environment if not already done so as mentioned here
  2. Go to <repo root>/sdk/cosmos/<package-name>
  3. run rushx lint
  4. Command in step 2 generates an html report in directory <repo root>/sdk/cosmos/<package-name> with name ends with lintReport.html
  5. All lint errors found in this package is listed on html report.

Once all known issues are resolved, below change is required in package.json file in package root <repo root>/sdk/cosmos/<package-name> to treat any new lint regression as hard failure in CI.

  • Remove following snippet from lint command in package.json
    -f html -o template-lintReport.html || exit 0

Note: HTML report name prefix may be different for each package name to differentiate the report for each package.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 23, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Aug 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 25, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Cosmos labels Aug 25, 2020
@ramya-rao-a ramya-rao-a added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated and removed Up for grabs labels Sep 15, 2020
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, MQ-2020 Nov 16, 2020
@deyaaeldeen deyaaeldeen modified the milestones: MQ-2020, [2021] March Feb 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants