[cosmos] Update runtime dependency "priorityqueuejs" #9314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeharder
requested review from
bterlson,
southpolesteve and
zfoster
as code owners
mikeharder
added
Cosmos
Client
|
I'm not sure either. This needs more investigation on our side to see if it causes problems. |
|
Closing since the JS team is owning dependency updates going forward. CC: @ramya-rao-a |
This was referenced Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the changelog, v2 "stops supporting component and browser builds":
I'm not sure exactly what this means and if it would prevent our package from working in browsers, so I created this PR to test it. If it does fail and we need to stay on v1, that's probably fine as well, but I want to know one way or the other.
Pipeline
js - cosmosdb - ciis green, but it doesn't appear to run browser tests, so I'm not sure if this proves whether the update is safe.