Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Regenerate swagger using Autorest Typescript v6 #9592

Closed
joheredi opened this issue Jun 17, 2020 · 2 comments
Closed

[Search] Regenerate swagger using Autorest Typescript v6 #9592

joheredi opened this issue Jun 17, 2020 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Search

Comments

@joheredi
Copy link
Member

joheredi commented Jun 17, 2020

This issue tracks the work to re-generate the sawgger using the latest version of @autorest/typescript

In order to use the new generator 2 changes need to be done in swagger/readme.md files

v3: true
use-extension:
  "@autorest/typescript": "6.0.0-dev.20200618.1"

Note
The latest @autorest/typescript version can be found here

@joheredi joheredi added Client This issue points to a problem in the data-plane of the library. Search labels Jun 17, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 18, 2020
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2020] August Jul 9, 2020
@sarangan12
Copy link
Member

@joheredi I tried this and autorest is complaining that it is not able to find it. So, I used --use command to pint to local build. Here, I am getting the following error:

src/generated/data/models/index.ts:795:18 - error TS2430: Interface 'DocumentsAutocompleteGetOptionalParams' incorrectly extends interface 'OperationOptions'.
  Types of property 'requestOptions' are incompatible.
    Type 'RequestOptions | undefined' is not assignable to type 'OperationRequestOptions | undefined'.
      Type 'RequestOptions' has no properties in common with type 'OperationRequestOptions'.

795 export interface DocumentsAutocompleteGetOptionalParams

Here, DocumentsAutocompleteGetOptionalParams is defined as:

export interface DocumentsAutocompleteGetOptionalParams  extends coreHttp.OperationOptions {
  /**
   * Parameter group
   */
  requestOptions?: RequestOptions;
  /**
   * Parameter group
   */
  autocompleteOptions?: AutocompleteOptions;
}

The requestOptions defined above and in coreHttp seems to be incompatible. Any ideas?

@sarangan12
Copy link
Member

V6 SDK Migration for Search Documents - completed with PR #12829

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

No branches or pull requests

4 participants
@sarangan12 @ramya-rao-a @joheredi and others