-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase Master to Identity-ENVVARs branch #10078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [FormRecognizer] Update CHANGELOG for preview.3 * parameter names for preview.3 should be `formUrl` and `receiptUrl` * More renaming * data => form/receipt * Update sdk/formrecognizer/ai-form-recognizer/CHANGELOG.md Co-authored-by: Krista Pratico <krpratic@microsoft.com> * logging whitelist * useTrainingLabels parameter now required * intervalInMs => updateIntervalInMs * Remove USReceipt for preview.3 Co-authored-by: Krista Pratico <krpratic@microsoft.com>
* Modified changelog for the June Release * Response to PR Comments * Dummy Commit I * Revert Dummy Commit
* [event-hubs] explain empty events * [event-hubs] readme update for 8798 * [event-hubs] migration-guide checkpointing 8419 * update changelog for 5.2.1 * Update sdk/eventhub/event-hubs/migrationguide.md Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> * Decided to be more ambitious for the release date Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
* Update Queue APIs aper the .NET proposal * remove @internal @ignore tags wherever required and generate API report * more exports * more and more exports * Add token credential constructor overlaod * doesExist() for queue, topic and subscription * generate API report * api extractor and ts-config (TO BE REVERTED) * feedback from the service team * update index.ts * update API report * Update queue related imports in tests * revert api-extractor and tsconfig changes to allow compiling tests * fix build failures of ATOM API tests * changes to rule options and interfaces * fix test failures * changes to Topic APIs * fix build failures * generate API report * subscription APIs updated * fix build failures * generate API report * fix API report warnings * changes to rule APIs * fix build failures * generate API report * getNamespaceProperties API * namespace info improvement + API report * fix warnings in the API report * generatre API report * resolve merge conflicts and organize imports * fix the warnings from API report * API report * tests for getRuntimeInfo API for a single entity * remove messageCount from *Description APIs * remove unused helper * test for Get namespace properties * tests for entityExists * tests for getEntitiesRuntimeInfo * Add changelog * Changelog * tokenProvider attempt to fix * added servicebus scope in the getToken attribute * mark "@azure/identity" as external * Token credential * test for Token credential - DefaultAzureCredential from `@azure/identity` * update the name * Update sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * Update sdk/servicebus/service-bus/src/serviceBusAtomManagementClient.ts Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * enter one more code path in the tests for gettoken invocation * refactoring the constructor as suggested by Chris and fixing tests * fix trailing slash issue * Update the test to cover more cases * fix test for AAD * remove unneeded ! * fix endpoint and endpointWithProtocol attributes * Add getToken for SasServiceCredential * merge tokenProvider into credentials * remove "@azure/ms-rest-nodeauth" from the external list in rollup config for tests * Update sdk/servicebus/service-bus/rollup.base.config.js Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * private sharedKeyCredential Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
* [ai-text-analytics] Various documentation-related fixes * Fixed use of showStats instead of includeStatistics * Added alternative TA product slug
…1.0.0 (#9346) * Removed a couple of old recordings * Changed all preview version indicators to 1.0.0
* Switch to using the CredentialUnavailable error * exporting CredentialUnavailable and fixing tests * updating api spec * fixed missed test update Co-authored-by: Scott Schaab <sschaab@microsoft.com>
The content of the comment in the method is the same as that described in `Databases.createIfNotExists()`, and it does not match the content of `Containers.createIfNotExists()`, so it was corrected.
…and servicefabric. (#9334)
* Update from master * version Co-authored-by: SDK Automation <sdkautomation@microsoft.com>
* Duplicated ThirdPartyNotices in eventhub * no more https://azure.github.io/azure-sdk-for-js links * other link fixes * new aka.ms links * docs/<service> to <service>/docs, as agreed upon over Teams * Changed https://aka.ms/azure-sdk-preview1-js to https://aka.ms/azsdk/releases/July2019Preview * removed the versions * Update README.md * lowercase july2019preview * lowercase july2019preview
* [event-hubs] improve migration guide checkpoint section * [event-hubs] make receciver disconnect even more tolerant! * Apply suggestions from code review Co-authored-by: Harsha Nalluru <sanallur@microsoft.com> Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
* Minor change in the sample * Additional changes
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
* ts sample * js sample * update samples readmes * readme updates for ATOM * Update sdk/servicebus/service-bus/samples/javascript/README.md Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
* Fix constant flattened property serialization * Update changelog * Update changelog
* 123 * update * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Simplify azure-identity error messaging * Azure.Identity simplify exception messaging * Azure.Identity simplify exception messaging * Azure.Identity simplify exception messaging * Simple change to try to re-run CI * Get building and test passing * Simplify error message and properly use CredentialUnavailable * Fix test Co-authored-by: Ziheng Zhou <v-zihz@microsoft.com> Co-authored-by: zzhxiaofeng <874256244@qq.com>
* Add "@azure/identity" to the external list for test rollup * undo AAD test comments * Update sdk/servicebus/service-bus/test/serviceBusClient.spec.ts Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> * remove unnecessary check Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
* [ai-text-analytics] Remove dangling code fence * [ai-text-analytics] De-localize links.
* [ai-text-analytics] add caveat note about TS 3.1 * patch
- Instrumenting abortSignal futher in the sender (going through init()). - Replacing the _checkAndSetupAbortSignalCleanup() pattern in _trySend() with the newer shared utility waitForTimeoutOrAbortOrResolve function. - Update launch.json so you can just hit F5 and run the unit tests target. Part of #4375
…fact parameter option in pipeline (#9948)
…eBusMessage and ATOM API (#10003) * Rename userProperties under ManagementClient too * fix test utils * rename userProps in the tests * one leftover * API Report * Changelog * fix build failure
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
…0018) In function `customConsoleLog()` we save `window.console.log` to a local variable and use this variable to log to real console. The problem is that when `customConsoleLog()` is called multiple times, `window.console.log` is no longer the original one, and we end up nesting the modified `log` function again and again. This PR saves the original console log function to a module level variable instead so it's not wrapped multiple times. * Allow overriding consoleLog for testing
…ded (#10013) We use an async function to add a recorded request to an array then save the array to files when recorder stops. However we did not wait for the async function to complete, which leads to recording missing requests. This issue only happens in the browser case. In Node it is done in synchronous way. This change makes recorder to wait until all the recorded requests are added before saving them. All the tests have been updated to await for `recorder.stop()`. Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
…we wait for all pollers (#10031) * [Key Vault Certificates] Test timeout need to be increased since now we wait for all pollers * dependency-testing timeout
* Azure SDK dev-tool first pass * [dev-tool] dev-tool dev-samples and fixes to all commands * Nested command structure * Better argument parsing, type-checking, and recursive command structure. Added support for running a single sample. * Added dev-tool README * [ai-text-analytics] Update package.json to use new script. * Removed some development cruft * prettier + eslint * Quick fix to ParsedOptions type * WIP * Command framework improvements * Basic unit-tests for package resolution. * One more test, assorted changes * README update * Migrated all packages with sample code to use dev-tool * Added dummy integration-test stub * Added dummy integration-test stub for eslint plugin * Added dummy integration-test:browser stubs * Added dev-tool dependency to packages using it * Corrected build:samples step in package.json * WIP * [dev-tool] ts-to-js command * [dev-tool] leaf command test * Fixed more deeply nested samples due to shared code
tzhanl
requested review from
bterlson,
chradek,
danieljurek,
daviwil,
HarshaNalluru,
sophiajt,
KarishmaGhiya,
mikeharder,
mitchdenny,
qiaozha,
ramya-rao-a,
richardpark-msft,
sadasant,
southpolesteve,
weshaggard and
xirzec
as code owners
July 15, 2020 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.