Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitor ci failures #10846

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Conversation

praveenkuttappan
Copy link
Member

@praveenkuttappan praveenkuttappan commented Aug 26, 2020

Monitor opentelemetry-exporter package is missing:

  • Changelog
  • sdk-type in package.json
  • ESlint error is not skipped (Separate issue to file for ESlint errors)
  • pack command is missing

Copy link
Member

@KarishmaGhiya KarishmaGhiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@praveenkuttappan
Copy link
Member Author

@markwolff I have updated dummy change log to complete change log check. Please update this with actual content when you get a chance. artifact name in ci.yml was misspelled and I have fixed it in this PR too.

@praveenkuttappan praveenkuttappan merged commit 9b97c78 into Azure:master Aug 26, 2020
@praveenkuttappan praveenkuttappan deleted the fix_monitor_ci branch August 26, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants