[communication] add some tnm tests #11628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0rland0Wats0n
requested review from
bterlson,
DominikMe,
RezaJooyandeh and
xirzec
as code owners
DominikMe
reviewed
Oct 3, 2020
...phonenumberadministrationclient_lists_playbacklive/recording_can_list_phone_plan_groups.json
Outdated
Show resolved
Hide resolved
...ommunication/communication-administration/src/phoneNumber/phoneNumberAdministrationClient.ts
Outdated
Show resolved
Hide resolved
DominikMe
reviewed
Oct 5, 2020
| @@ -133,6 +133,7 @@ export type GetAreaCodesOptions = OperationOptions; | |||
| // @public | |||
| export interface GetAreaCodesRequest { | |||
| countryCode: string; | |||
| locationOptionsQueries: LocationOptionsQueries; | |||
There was a problem hiding this comment.
// @public
export interface LocationOptionsQuery {
labelId?: string;
optionsValue?: string;
}^ those two props shouldn't be optional right? Another bug.
There was a problem hiding this comment.
yep another one
DominikMe
approved these changes
Oct 5, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 4, 2021
add automation track2 config (Azure#11628) * add automation track2 config * update config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.