[MetricsAdvisor] change timestamps type from Date to number #12162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
bterlson,
KarishmaGhiya and
xirzec
as code owners
| @@ -25,7 +25,7 @@ export interface AnomalyAlert { | |||
| createdOn?: Date; | |||
| id: string; | |||
| modifiedOn?: Date; | |||
| timestamp?: Date; | |||
| timestamp?: number; | |||
There was a problem hiding this comment.
Is this decision meant for all the packages?
(Asking for service-bus, I was hoping I'd change a "number" to "Date", but that doesn't seem like it?)
There was a problem hiding this comment.
@bterlson suggested that a timestamp should be a number or string
jeremymeng
force-pushed
the
ma-use-number-for-timestamp
branch
from
2ae717c to
bf6c272
Compare
|
@jeremymeng This looks good to me. Do we need to make any updates to our samples? |
KarishmaGhiya
approved these changes
Nov 3, 2020
I don't think we depends on the types of these properties. They are in output/result types. We only call |
|
@jeremymeng Do we need Changelog updates here? |
Done |
This addresses one of the Arch Board review feedback. I still keep the timestamps in MetricSeriesData and MetricEnrichedSeriesData as Date type because their most common usage is plotting because keeping them as Date make it easier to use year/month/date in x-axis labels.
jeremymeng
force-pushed
the
ma-use-number-for-timestamp
branch
from
faf5c5e to
84aac0b
Compare
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 28, 2020
Swagger Linting Fix (Azure#12162) * Fix Linting Issuing * no message * fix description * add description and object back * test to resolve model validation test (cherry picked from commit ab273dfc0d5897683c128ee15da4babafa7a85ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one of the Arch Board review feedback. I still keep the
timestamps in MetricSeriesData and MetricEnrichedSeriesData as Date
type because their most common usage is plotting because keeping them as Date
make it easier to use year/month/date in x-axis labels.
This fixes #11832