-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core AMQP cleanup for v2 #12210
Merged
Merged
Core AMQP cleanup for v2 #12210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
force-pushed
the
cleaner-core-amqp
branch
from
November 1, 2020 06:08
73afa2a
to
282781b
Compare
ramya-rao-a
requested review from
bterlson,
chradek,
HarshaNalluru,
richardpark-msft and
xirzec
as code owners
November 1, 2020 21:42
9 tasks
|
||
We are cleaning the public API surface by | ||
|
||
- removing exports that are either not used by either `@azure/event-hubs` and `@azure/service-bus` packages (which are the two main consumers of this package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT
Suggested change
- removing exports that are either not used by either `@azure/event-hubs` and `@azure/service-bus` packages (which are the two main consumers of this package) | |
- removing exports that are neither used by `@azure/event-hubs` nor `@azure/service-bus` package (which are the two main consumers of this package) |
HarshaNalluru
approved these changes
Nov 2, 2020
richardpark-msft
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, core-amqp feels much healthier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the points in #12116 (comment) to clean the public API surface of
@azure/core-amqp
package.Context:
@azure/amqp-common
is the package with common code for Event Hubs v2 and Service Bus v1 packages. When we started working on Event Hubs v5 based on the new guidelines, we copied this package, named it@azure/core-amqp
, added TokenCredential support and made it easier to have retries. What we missed was doing a cleanup of things that we don't really need exported from here.This PR does the said cleanup as follows:
@azure/core-amqp
and copying them to Service Bus and Event Hubs packagescredential
from theConnectionContextBase
in@azure/core-amqp
and have theConnectionContext
in SB & EH packages house itnegotiateClaim()
to take token string instead of theAccessToken
. With this,@azure/core-amqp
need not re-export things from@azure/core-auth
@azure/core-amqp
EventHubConnectionConfig
is moved to EH package along with its testsrhea-promise
. EH & SB already have a dependency on this and can use things from it directlyEH live tests and SB live tests have been run