[Core AMQP] V2 - Remove DefaultDataTransformer from the exports #12320
Conversation
HarshaNalluru
requested review from
bterlson,
chradek,
ramya-rao-a,
richardpark-msft and
xirzec
as code owners
ghost
added
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| ## 2.0.0 (Unreleased) | |||
|
|
|||
| ### Breaking changes | |||
|
|
|||
| - `DefaultDataTransformer` is no longer exported. | |||
There was a problem hiding this comment.
Not exporting the DefaultDataTransformer, but continuing to export DataTransformer interface does not give us much. The main reason for us to do this is to keep the option open in the future to implement the "serializer" in any other way.
I would recommend removing the dataTransformer property from ConnectionContextBase to allow us to stop exporting this interface from core-amqp. This will result in copying the code in the DefaultDataTransformer to Service Bus and EventHubs and use it like a static class instead of using it from the context.
In the future when we have the common code between SB & EH without needing to expose it users from core-amqp, we can move this
…mqp to client packages (#12415) Part of the list of breaking changes to core-amqp v2 in #12116 Replaces #12320 (precipitated by #12320 (comment)) This change moves the `DataTransformer` interface and `DefaultDataTransformer` class to service-bus and event-hub packages. When we establish what our data serde strategy is, we can revisit using a shared common serde solution.
|
Closing in favour of Chris's PR for the same! |
Part of V2 Breakign changes #12116