Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus]Update tests for improved describe and it names #1237

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

ramya-rao-a
Copy link
Contributor

Fixes #1231 with the below rules:

  • describe sections to have short names
  • each it starts with entity type (queue/subscription/topic partition/unpartition session)
  • exception to the previous point are the renewLock files that group tests by entity
  • When running locally, it is the individual test names that show up. These should be self explanatory
  • When running in CI, the failed tests have the describe section's name prefixed, making the entire text long. This text should be self explanatory without needing to scroll till the end. This is done by ensuring the information in the describe section when repeated in the tests appears in the end.

@ramya0820 Did you have any other points in mind when you logged #1231?

Copy link
Member

@ramya0820 ramya0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we organize all tests to mimic renew lock tests structure?
    The organization we have based on entities is less error prone if in future we modify tests that we want to add
    For the other tests, it's currently not that easy to replicate/copy-paste any new/modofied tests as it is in renewLock tests.

  • Also, the message prefix construction is still not uniform, I think having something like below for all tests would help.
    <entity type (Queue/Topic)> <feature-1 (Partition/Unpartitioned> <feature-2 (Session/Non-session)> <test-title> <test-case-title>

  • Above is also easier to extend across namespaces for later.

@ramya0820
Copy link
Member

Discussed offline, approving this PR as we wanted to just modify the text a little for now and pick up remaining items in issue later.

@ramya0820 ramya0820 closed this Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
@ramya-rao-a ramya-rao-a reopened this Feb 15, 2019
@ghost ghost added the in progress label Feb 15, 2019
@ramya-rao-a ramya-rao-a merged commit ec91694 into Azure:master Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
HarshaNalluru pushed a commit to HarshaNalluru/azure-sdk-for-js that referenced this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Service Bus] Re-structure tests to group by entities instead of test cases
3 participants