-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus]Update tests for improved describe and it names #1237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Can we organize all tests to mimic renew lock tests structure?
The organization we have based on entities is less error prone if in future we modify tests that we want to add
For the other tests, it's currently not that easy to replicate/copy-paste any new/modofied tests as it is in renewLock tests. -
Also, the message prefix construction is still not uniform, I think having something like below for all tests would help.
<entity type (Queue/Topic)> <feature-1 (Partition/Unpartitioned> <feature-2 (Session/Non-session)> <test-title> <test-case-title>
-
Above is also easier to extend across namespaces for later.
Discussed offline, approving this PR as we wanted to just modify the text a little for now and pick up remaining items in issue later. |
Fixes #1231 with the below rules:
it
starts with entity type (queue/subscription/topic partition/unpartition session)@ramya0820 Did you have any other points in mind when you logged #1231?