Move event hubs repo into this repo #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lace in the sdk from where an AMQP connection is established.
…for management client is accurate for iothub and eventhub client.
Added support for iothub connectionstring and refactored the design
…othub connection string.
Send messages with partition key correctly
minor updates to the EH client and EPH
Use isItselfClosed() to determine if sdk initiatied close
amqp-common 0.1.4 and later introduced a different error for the invalid endpoint of "abc". This change update the endpoint so that we can still test the missing path error, which technically is a different error thrown from a different method starting from amqp-common 0.1.4 or later. It just have the same error type and error message as the old one.
- Add build configuration from sdk template - Fix tsc and tslint errors - Add a README.md for client examples - Bump version to 2.0.0-preview.1
Apply build configuration from sdk template to client
- Fix tsc and tslint errors. - Add rollup configurations. - Pass `--exit` to Mocha. The old `unit` run script does the same to force Mocha to exit after tests complete running. Our tests hold onto active timers at the end so without this option Mocha will not exit until after 45 minutes. See Azure/azure-event-hubs-node#188 for more details. Also increasing test timeout. - Bump package versions. - Remove usage of `path-browserify`. According to https://github.com/browserify/path-browserify#install, Node.js has `path` built-in, and for browsers, bundlers like browserify or webpack include the `path-browserify` module by default. - Upgrade `nyc` to fix the npm audit warning.
Apply build configuration from template for EPH
ghost
added
the
|
The only new change is moving things into the |
|
Need another change to disable auto publishing of the package |
|
@AlexGhiondea Service bus was moved under |
|
@ramya-rao-a when I moved Service Bus we had a different understanding of how the structure was going to look like -- the structure is now different. I wouldn't put it under the data-plane folder now. |
ramya-rao-a
approved these changes
Feb 15, 2019
|
Got it @AlexGhiondea |
|
I made the change in the old PR but decided not to do it now as there is a guidance on the directory structure coming. |
…move-event-hubs-repo
And disable the automatic publishing for eventhubs packages
jeremymeng
force-pushed
the
move-event-hubs-repo
branch
from
085a37b to
a7f0023
Compare
HarshaNalluru
pushed a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2019
Move event hubs repo into this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.