[service-bus] loosens parameter type in isServiceBusError type guard #12493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
added
Client
chradek
requested review from
bterlson,
HarshaNalluru,
ramya-rao-a,
richardpark-msft and
xirzec
as code owners
chradek
changed the title
ramya-rao-a
reviewed
Nov 11, 2020
| ): err is ServiceBusError { | ||
| return (err as Error | ServiceBusError).name === "ServiceBusError"; | ||
| export function isServiceBusError(err: unknown): err is ServiceBusError { | ||
| return (err as Error | ServiceBusError)?.name === "ServiceBusError"; |
There was a problem hiding this comment.
can this not be just (err as Error) instead of (err as Error | ServiceBusError)?
There was a problem hiding this comment.
Updates err: unknown to be err: any so I don't have to cast err at all in this line. For our purposes, any works fine.
ramya-rao-a
approved these changes
Nov 12, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 20, 2021
[Fix broken S360 Issues][HDInsight] Fix S360 issues batch2 (Azure#12493) * Add networkProperties and clusterId * Add display.description and properties of operation. Fix DeletionOperationResponse linting error Add privateIPAddress in ConnectivityEndpoints and ApplicationGetEndpoints * Fix model validation error: update example Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12264
The goal with this change is to prevent exposing the
AmqpErrortype to end-users. To accomplish this, theerrparameter passed toisServiceBusErrorhas been changed to beunknown. This doesn't change how the type guard can be used (while it is now more permissive, the end result should be the same.)I did not add an entry to the changelog for this change since it doesn't change how
isServiceBusErrorworks, it just allows anything to be passed to it now without a compilation error. If this is a notable change I can add it to the changelog.