Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App configuration migration #13095

Merged
merged 6 commits into from
Jan 14, 2021
Merged

App configuration migration #13095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
157d543
Generated Code changes
sarangan12 Jan 6, 2021
d7cd389
Custom Code Changes
sarangan12 Jan 6, 2021
07a8a3a
Formatting Changes
sarangan12 Jan 6, 2021
e2a524f
Configuration Readme Changes
sarangan12 Jan 6, 2021
bddd4e2
Add Transformations
sarangan12 Jan 8, 2021
3804395
Add Hidden to Client Classes & Update Version Tool
sarangan12 Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/appconfiguration/app-configuration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@
{
"path": "src/appConfigurationClient.ts",
"prefix": "packageVersion"
},
{
"path": "src/generated/src/appConfigurationContext.ts",
"prefix": "packageVersion"
}
]
},
Expand Down
13 changes: 8 additions & 5 deletions sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ import {
import { tracingPolicy } from "@azure/core-http";
import { Spanner } from "./internal/tracingHelpers";
import {
GetKeyValuesResponse,
AppConfigurationOptions as GeneratedAppConfigurationClientOptions
AppConfigurationGetKeyValuesResponse,
AppConfigurationOptionalParams as GeneratedAppConfigurationClientOptions
} from "./generated/src/models";
import { syncTokenPolicy, SyncTokens } from "./internal/synctokenpolicy";

Expand Down Expand Up @@ -169,6 +169,7 @@ export class AppConfigurationClient {

this.client = new AppConfiguration(
appConfigCredential,
appConfigEndpoint,
apiVersion,
getGeneratedClientOptions(appConfigEndpoint, syncTokens, appConfigOptions)
);
Expand Down Expand Up @@ -357,7 +358,9 @@ export class AppConfigurationClient {
}
}

private *createListConfigurationPageFromResponse(currentResponse: GetKeyValuesResponse) {
private *createListConfigurationPageFromResponse(
currentResponse: AppConfigurationGetKeyValuesResponse
) {
yield {
...currentResponse,
items: currentResponse.items != null ? currentResponse.items.map(transformKeyValue) : []
Expand Down Expand Up @@ -512,7 +515,7 @@ export class AppConfigurationClient {
* @hidden
*/
export function getGeneratedClientOptions(
baseUri: string,
endpoint: string,
syncTokens: SyncTokens,
internalAppConfigOptions: InternalAppConfigurationClientOptions
): GeneratedAppConfigurationClientOptions {
Expand All @@ -528,7 +531,7 @@ export function getGeneratedClientOptions(
);

return {
baseUri,
endpoint,
deserializationContentTypes,
// we'll add in our own custom retry policies
noRetryPolicy: true,
Expand Down
Loading