Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint plugin] Upgrade node to v10 #13211

Merged
3 commits merged into from
Mar 18, 2021
Merged

Conversation

deyaaeldeen
Copy link
Member

The linter test suite fails using node8 in this PR: #13162. ESLint v7.15 supports node10.12.0 and up only.

@deyaaeldeen deyaaeldeen marked this pull request as ready for review January 14, 2021 02:18
@deyaaeldeen deyaaeldeen requested a review from ramya-rao-a March 17, 2021 20:21
@ghost
Copy link

ghost commented Mar 17, 2021

Hello @deyaaeldeen!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@deyaaeldeen deyaaeldeen force-pushed the eslint-plugin-node10 branch from 8ff8e17 to 8961994 Compare March 18, 2021 16:22
@ghost ghost merged commit e35b189 into Azure:master Mar 18, 2021
@deyaaeldeen deyaaeldeen deleted the eslint-plugin-node10 branch March 18, 2021 17:18
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
The linter test suite fails using node8 in this PR: Azure#13162. ESLint v7.15 supports node10.12.0 and up only.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants