[App Config] Fix linting errs on missing return types #13687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
chradek and
richardpark-msft
as code owners
ghost
added
the
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @ramya-rao-a! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
deyaaeldeen
approved these changes
Feb 9, 2021
Comment on lines
+139
to
140
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| addEventListener: () => {}, |
There was a problem hiding this comment.
I think this would satisfy the rule.
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-empty-function | |
| addEventListener: () => {}, | |
| addEventListener: () => { /* empty function */ }, |
Comment on lines
+141
to
142
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| removeEventListener: () => {} |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-empty-function | |
| removeEventListener: () => {} | |
| removeEventListener: () => { /* empty function */ } |
Comment on lines
+152
to
153
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| validateRequestProperties: () => {}, |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-empty-function | |
| validateRequestProperties: () => {}, | |
| validateRequestProperties: () => { /* empty function */ }, |
| @@ -270,7 +273,7 @@ describe("helper methods", () => { | |||
| "value" | |||
| ]); | |||
|
|
|||
| assert.ok(formatFieldsForSelect(undefined) == undefined); | |||
| assert.ok(formatFieldsForSelect(undefined) === undefined); | |||
There was a problem hiding this comment.
Suggested change
| assert.ok(formatFieldsForSelect(undefined) === undefined); | |
| assert.isUndefined(formatFieldsForSelect(undefined)); |
ghost
merged commit
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 29, 2021
correct changeanalysis typescript.md (Azure#13687)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.