Cosmos: project depends on azure/identity #14237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package.json for the project needs to have the identity package within its dependencies, not the dev dependencies, or else it will cause problems when building in TypeScript projects. This: - moves the package from dev deps to deps - moves a types package from deps to dev deps Note, there is reference to a library called @azure/dev-tool that is not published, so I am unable to run tests. See also: - #13202 - #14236
ghost
added
Cosmos
customer-reported
|
Thank you for your contribution jeffwilcox! We will review the pull request and get back to you soon. |
zfoster
approved these changes
Mar 11, 2021
|
thanks @jeffwilcox |
|
@jeffwilcox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package.json for the project needs to have the identity package
within its dependencies, not the dev dependencies, or else it will
cause problems when building in TypeScript projects.
This:
Note, there is reference to a library called @azure/dev-tool that
is not published, so I am unable to run tests.
See also: