Eventgrid arm package is not packaged due to matching service and dat… #14301
Conversation
…aplane folder name
praveenkuttappan
requested review from
mikeharder,
ramya-rao-a,
jeremymeng,
KarishmaGhiya,
qiaozha and
HarshaNalluru
|
fix issue #14302 |
praveenkuttappan
added
the
Central-EngSys
| if (!contains(folderNamesToIgnore, getName(folderPath))) { | ||
| // If current path is not in folder to ignore list then process it. | ||
| return true; |
There was a problem hiding this comment.
I think this returns true for the track 1 perf test packages since it isn't a rush package.
Track 1 perf test packages should also be ignored.
Logged a new issue to handle this case #14304.
There was a problem hiding this comment.
@HarshaNalluru : Do we need any more change in this PR or is it good to merge?
There was a problem hiding this comment.
This looks good. (perf track 1 can be handled in a separate PR.)
But I think if you can elaborate in comments with examples on what gets filtered at each step, it would help a lot.
|
@ramya-rao-a @jeremymeng : Can one of you please have a look at this PR and sign off too if this change looks fine? |
| @@ -112,14 +112,31 @@ function isPackageFolderPath(folderPath: string, packagesToIgnore: string[]): bo | |||
| return result; | |||
| } | |||
|
|
|||
| function shouldProcessFolderPath(folderPath: string, folderNamesToIgnore: string[]): boolean { | |||
| if (!contains(folderNamesToIgnore, getName(folderPath))) { | |||
There was a problem hiding this comment.
It looks harder to understand.
Would it help better if you add a comment above with an example?
Such as..
folderNamesToIgnore = [ "service-bus", "eventgrid", ... ]; // Coming from /sdk/service/<service-sdk-name>
folderPath = "..../sdk/servicebus/service-bus"
getName(folderPath) = "service-bus" There was a problem hiding this comment.
Similarly, at other places too.
|
Could we get this PR merged now ? |
…aplane folder name (Azure#14301)
Add configuration to generate AppPlatform SDK for API version 2021-06-01-preview (Azure#14301) * Add configuration to generate AppPlatform SDK for API version 2021-03-03-preview * Update AutoRest configuration after api-version change in Azure#14323
arm-eventgridpackage is not packed when building arm packages. Upon investigation I have noticed thateventgridservice path./sdk/eventgriditself skipped when traversing all paths in SDK root path so gulp packing step is not findingarm-eventgridas an eligible package to be packed.Reason: service name and data plane name is same in this case for eventgrid (
eventgrid). All data plane package names are considered as folders to be ignored when traversing paths and this logic doesn't check whether current folder is a package root or not. So it skips traversing./sdk/eventgridpath further which causes to ignorearm-eventgridalso.Solution: Ensure that path is package root when skipping that folder from further traversal.