-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove testhub utility package #14678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
requested review from
bterlson,
HarshaNalluru,
mikeharder,
praveenkuttappan,
ramya-rao-a and
richardpark-msft
as code owners
April 2, 2021 17:40
ghost
added
the
Event Hubs
label
Apr 2, 2021
ramya-rao-a
suggested changes
Apr 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following files need to be updated as well
- sdk/eventhub/.vscode/launch.json
- dataplane.code-workspace
- .docsettings.yml
chradek
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
April 2, 2021 17:58
Ah, thanks! I never use the dataplane workspaces or the vscode launch config so completely forgot those existed. Just did a grep for testhub in the repo and don't see anything else. |
HarshaNalluru
approved these changes
Apr 2, 2021
ramya-rao-a
approved these changes
Apr 2, 2021
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
* Remove testhub CLI utility from repo * update pnpm-lock.yaml * remove vestigal traces of testhub
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 7, 2021
Updating version to 2021-06-01 for recoveryservicesbackup (Azure#14678) * Updating version to 2021-06-01 for msi support for iaasvm * adding example files * resolving comments * fixing validation issue * undoing package-lock changes * fixing validation errors * fixing non-identical model issue * fixing lintdiff error * fixing lintdiff error * append * Update readme.md * adding suppression * Update readme.md * Update readme.md * contract update * renaming managedidentityid * fixing prettier check * reversing the exposure of identity url * Update bms.json * Update bms.json Co-authored-by: monjain <35448521+monjain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1251
The testhub package was a CLI tool used to test the track1 messaging libraries. The messaging libraries have all been updated to track2 with their own set of stress/perf tests.
Removing this package as it is no longer relevant (sorry testhub!)