Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testhub utility package #14678

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Remove testhub utility package #14678

merged 3 commits into from
Apr 2, 2021

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Apr 2, 2021

Resolves #1251

The testhub package was a CLI tool used to test the track1 messaging libraries. The messaging libraries have all been updated to track2 with their own set of stress/perf tests.

Removing this package as it is no longer relevant (sorry testhub!)

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following files need to be updated as well

  • sdk/eventhub/.vscode/launch.json
  • dataplane.code-workspace
  • .docsettings.yml

@chradek
Copy link
Contributor Author

chradek commented Apr 2, 2021

Ah, thanks! I never use the dataplane workspaces or the vscode launch config so completely forgot those existed.
(And I just forgot about docsettings!)

Just did a grep for testhub in the repo and don't see anything else.

@chradek chradek merged commit aad8e1c into Azure:master Apr 2, 2021
@chradek chradek deleted the rm-test-hubs branch April 2, 2021 18:44
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
* Remove testhub CLI utility from repo

* update pnpm-lock.yaml

* remove vestigal traces of testhub
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jul 7, 2021
Updating version to 2021-06-01 for recoveryservicesbackup (Azure#14678)

* Updating version to 2021-06-01 for msi support for iaasvm

* adding example files

* resolving comments

* fixing validation issue

* undoing package-lock changes

* fixing validation errors

* fixing non-identical model issue

* fixing lintdiff error

* fixing lintdiff error

* append

* Update readme.md

* adding suppression

* Update readme.md

* Update readme.md

* contract update

* renaming managedidentityid

* fixing prettier check

* reversing the exposure of identity url

* Update bms.json

* Update bms.json

Co-authored-by: monjain <35448521+monjain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out what to do with packages/@azure/eventhubs/testhub
3 participants