[service-bus] Add support for sending AmqpAnnotatedMessage (and control destination section of body) #14703
Conversation
the body is encoded in the sent message (via the `bodyType`) field.
richardpark-msft
requested review from
bterlson,
chradek,
HarshaNalluru,
ramya-rao-a and
xirzec
as code owners
ghost
added
richardpark-msft
requested review from
yunhaoling,
JoshLove-msft and
hemanttanwar
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| export function isRheaAmqpSection( | ||
| possibleSection: any | RheaAmqpSection | ||
| ): possibleSection is RheaAmqpSection { | ||
| return possibleSection != null && typeof possibleSection.typecode === "number"; |
There was a problem hiding this comment.
Shouldnt it also have a "content"?
There was a problem hiding this comment.
Do you mean this?
/** @internal */
export function isRheaAmqpSection(
possibleSection: any | RheaAmqpSection
): possibleSection is RheaAmqpSection {
return (
possibleSection != null &&
typeof possibleSection.typecode === "number" &&
isDefined(possibleSection.content)
);
}There was a problem hiding this comment.
Updated to that.. let me know what you think.
| return ( | ||
| possibleSection != null && | ||
| typeof possibleSection.typecode === "number" && | ||
| isDefined(possibleSection.content) |
There was a problem hiding this comment.
Is it possible for the content to be null/undefined? What if I had sent a message with no body, but all other properties set?
There was a problem hiding this comment.
Yeah, I'd leave out the content check . We could possibly improve this by making sure typecode is one of the 3 values we accept, otherwise I think it's a "good enough" check for something used internally.
There was a problem hiding this comment.
Just checked.. it can be undefined/null.
One observation.. If set undefined and sent, it comes back as null.
There was a problem hiding this comment.
Added the check to make sure the received typecode is of the expected ones.
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit #14703 missed a few things while translating Annotated message into RheaMessage. This PR attempts to fill the gaps.
Adding in support to send AmqpAnnotatedMessage and also to control where the body is encoded in the sent message (via the
bodyType) field.