[Anomaly Detector] Regenerate and remove manual parts #14912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
bterlson,
chradek,
ramya-rao-a and
xirzec
as code owners
joheredi
commented
Apr 16, 2021
| listMultivariateModel(options?: ListMultivariateModelOptionalParams): Promise<AnomalyDetectorClientListMultivariateModelResponse>; | ||
| listMultivariateModelNext(nextLink: string, options?: ListMultivariateModelNextOptionalParams): Promise<AnomalyDetectorClientListMultivariateModelNextResponse>; | ||
| trainMultivariateModel(modelRequest: AnomalyDetectorClientModelInfo, options?: TrainMultivariateModelOptions): Promise<AnomalyDetectorClientTrainMultivariateModelResponse>; | ||
| export class AnomalyDetectorClient extends AnomalyDetectorClientBase { |
There was a problem hiding this comment.
@lmazuel - FYI this is the API surface. The remaining manual code is just a class extending the generated client to add support for Key Credential.
The operations are all in the generated client AnomalyDetectorClientBase, no change in the name of the operations or return types.
deyaaeldeen
approved these changes
Apr 16, 2021
sdk/anomalydetector/ai-anomaly-detector/review/ai-anomaly-detector.api.md
Outdated
Show resolved
Hide resolved
sdk/anomalydetector/ai-anomaly-detector/review/ai-anomaly-detector.api.md
Outdated
Show resolved
Hide resolved
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
* regenerate and remove manual parts * Update samples * Regenerate names * update command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating using the latest Generator version and removing manual parts as they are now auto generated. Keeping the constructor to be able to support Key credential as it is not autogenerated yet.