Improve mgmt readme for identity support #14921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
mikeharder and
praveenkuttappan
as code owners
ramya-rao-a
requested review from
sadasant,
deyaaeldeen,
qiaozha and
joheredi
and removed request for
mikeharder and
praveenkuttappan
|
@deyaaeldeen Can we please update the code generator with similar changes? |
|
@ramya-rao-a Yes I will, I opened this issue for tracking: Azure/autorest.typescript#916. |
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 12, 2021
DataBoxEdge Swagger API Review- 2021-02-01 (Azure#14921) * Initial Commit with previously reviewed Changes * Updated Swagger * Added Example files * Updated Description for the APIs which are in private preview * Updated ReadmeFiles * Fixed folder structure * fixed json example references * Fixed supportPackage and Proactivelogcollection jsons * Fixed Prettier check * Fixed Prettier check * Fixed Azure-auth * Fixing UpdateDiagnosticRemoteSupportSettings.json Go Validations * Fixed Model Validation * Fix Model Validation + Prettier Check * Fixed Model Validation * Swagger LinterValidation Fix * Removed Type from UpdateDiagnosticProactiveLogCollectionSettings.json, failing Model Validation * Updated all the example files * fixed comments * Updated corresponding examples * Fixed Validation * Updated the tag to the latest * Fixed the tag Co-authored-by: Arzoo Jain <arja@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add-identity-mgmt-lib.jsis the script that can be used on auto-generated mgmt plane packages to make them support the credentials from the@azure/identitypackageWe had feedback regarding the updated readme that the use of
DefaultAzureCredentialrequires set up while the older readme used interactive credential from ms-rest-nodeauth which did not require any set up and so was easy to get started.In all the data plane packages that use the new Identity package across all languages, we have been using
DefaultAzureCredentialin our examples and getting started guides. If we are to change our getting started story, that would involve a larger effort cross languages and cross packages.In order to unblock the current efforts to have the mgmt plane packages support Azure Identity, we will rely on the doc https://aka.ms/azsdk/js/identity/examples. See #14920 for the improvements being done to this doc which will make it easier for us to simply point to this doc rather than go into details of which credential is easiest for getting started in the readme file of the consuming package.