[KeyVault] - Remove KeyOperationsOptions from public API #14930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maorleger
requested review from
bterlson,
chradek,
sadasant and
xirzec
as code owners
sadasant
approved these changes
Apr 19, 2021
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
## What - Remove `KeyOperationOptions` from cryptography API and use `CryptographyOptions` everywhere ## Why `KeyOperationsOptions` was used as a common placeholder for `iv`, `additionalAuthenticatedData`, and `authenticationTag` up until very recently: https://github.com/Azure/azure-sdk-for-js/pull/13889/files#diff-7e7a216d0920c250e6742ecece9de13be1712657c97776fbfbfec386896cab13L141-L155 Because we moved to using `EncryptParameters` and `DecryptParameters` for these parameters we no longer need a common type for a subset of cryptography operations. This PR just cleans up the public API a bit before we GA.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 5, 2021
[Hub Generated] [SiteRecovery] Review request for Microsoft.RecoveryServices to add version stable/2021-04-01 (Azure#14930) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-02-10 to version 2021-04-01 * Updates readme * Updates API version in new specs and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
KeyOperationOptionsfrom cryptography API and useCryptographyOptionseverywhereWhy
KeyOperationsOptionswas used as a common placeholder foriv,additionalAuthenticatedData, andauthenticationTagup until very recently: https://github.com/Azure/azure-sdk-for-js/pull/13889/files#diff-7e7a216d0920c250e6742ecece9de13be1712657c97776fbfbfec386896cab13L141-L155Because we moved to using
EncryptParametersandDecryptParametersfor these parameters we no longer need a common type for a subset of cryptography operations. This PR just cleans up the public API a bit before we GA.