[identity] Remove machine-code-dependent codepaths #15024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witemple-msft
added
Client
witemple-msft
requested review from
bterlson,
chradek,
daviwil,
maorleger,
schaabs and
xirzec
as code owners
|
/azp run js - identity - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
CI passed:
|
sadasant
reviewed
Apr 26, 2021
sdk/identity/identity/test/internal/node/interactiveBrowserCredential.spec.ts
Show resolved
Hide resolved
sadasant
approved these changes
Apr 26, 2021
|
/check-enforcer override |
|
Any guidance on how to utilize this version, not seeing beta.3 on npmjs. Currently having major issues with app service deployments due to keytar and node-gyp |
witemple-msft
added a commit
that referenced
this pull request
Jun 21, 2021
…-persistence (#15384) * [identity] Remove machine-code-dependent codepaths (#15024) * [identityg Remove machine-code-dependent codepaths * Linter fixes * Disable broken perf test * Added missing import back * [identity] Add extension registration API and default credential stack * [identity-native] Introducing identity-native * [identity] Rework extension API. * Remove identity native * Identity-persistence module * Adding identity-vscode module * Updated rush configuration * Moved identity perf back to linking local identity * Symbolic refactor of extension system * Renamed MsalCredentialOptions to CacheableCredentialOptions * Use Symbol.for instead of hacking around SymbolConstructor * Improved identity-vscode samples * Use persistence by default if a persistence provider has been registered. * Improved identity-persistence samples * Rename to identity-cache-persistence * Feedback from arch board for mainline identity package * Rename CredentialPersistenceOptions, format and lint * Revert sanitization of scopes. * Regenerated API.md for mainline identity * Add tests and finalize @azure/identity-cache-persistence * Record tests for identity-cache-persistence * Renamed sample files. * Some changes for testing in identity * Updated identity-vscode * Remove async version of useIdentityExtension * Added a couple of tests for default no-extension behavior * Fixed tests in recorder * Removed errant console.log * Added basic tests of identity-vscode * Fixed a couple of tests that have started caching correctly * Added browser shim for extensions/consumer.ts * Mock keytar using sinon in live/playback environments * Disable persistence tests on node !== 12 * Addressed feedback in identity-cache-persistence * Restore perf-test * Removed sanitizeScopeUrl from recorder * Update sdk/identity/identity/src/credentials/visualStudioCodeCredential.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Fix gitignores * Feedback for identity-vscode * Changelog entry for recorder changes. * core-http -> core-auth * setter methods instead of setter props * Some changes to docs and keywords * Fixed linter warning * Switch persistence tests from 12 to 14. * Make the tests even refuse to import msal-node-extensions on anything other than Node 14 * Reverted changes to recorder * master -> main * More master -> main * [identity] Make the samples extract only part of the token data Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 8, 2021
Fixing swagger correctness and completeness issues for RecoveryServicesBackup (Azure#15024) * Fixing swagger correctness and completeness issues for RecoveryServicesBackup * Adding examples * Fixing swagger completness * Updating tag in 2021-04-01 * Update * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all codepaths from
@azure/identitythat are dependent on native machine code modules.VisualStudioCodeCredential@azure/msal-node-extensionsoptionalDependencyonkeytar.This also involved the removal of many tests related to the persistence API. We plan to reintroduce this code within a separate package.