Metrics updates #15125
Metrics updates #15125
Conversation
KarishmaGhiya
requested review from
bterlson,
chradek,
jeremymeng and
xirzec
as code owners
ghost
added
the
| /** | ||
| * value of the anomaly | ||
| */ | ||
| value?: number; |
There was a problem hiding this comment.
should value and expectedValue be readonly? Do they always have values (non-optional)?
There was a problem hiding this comment.
On the generated layer these are optional and readonly. Anu has asked on the service channel to clarify if they can have null values. Maybe we can wait till then.
| /** | ||
| * data used to implement value filter | ||
| */ | ||
| type?: "Value" | "Mean"; |
There was a problem hiding this comment.
is this optional or non-optional?
There was a problem hiding this comment.
On the generated layer these are optional.
There was a problem hiding this comment.
what type is this? Hard to guess its meaning. Please ask service team about it.
| /** | ||
| * dimensions used to split alert | ||
| */ | ||
| splitAlertByDimensions?: string[]; |
There was a problem hiding this comment.
dimensionsToSplitAlerts better?
There was a problem hiding this comment.
Will follow up on this after discussing with crew. Otherwise we'll make this change for JS only
Fixing operation name (Azure#15125) * Fixed operation name. * Fixed readme. * Fixed titles.
typeto each of the three the boundary condition union typessplitAlertByDimensions?: string[];toAnomalyAlertConfigurationIncidentPropertyandAnomalyProperty, ensure we have new properties in our model types (flattened):DataPointAnomalyandAnomalyIncident