Revert "Pin identity dev dependency to avoid re-recording" #15126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
0rland0Wats0n,
ankitarorabit,
deyaaeldeen,
DominikMe,
EmmaZhu,
HarshaNalluru,
jeremymeng,
jiacfan,
KarishmaGhiya,
LarryOsterman,
ljian3377,
mikeharder,
praveenkuttappan,
ramya-rao-a,
sadasant,
vinjiang,
vishnureddy17,
XiaoningLiu and
a team
as code owners
ghost
added
Communication
Digital Twins
KeyVault
Storage
HarshaNalluru
approved these changes
May 4, 2021
|
No lock file generated? |
|
@HarshaNalluru just to sanity check I ran rush update again and no lockfile changes - do you expect it to / are very surprised? If so happy to investigate more! |
ramya-rao-a
approved these changes
May 4, 2021
No, was just confirming. I think |
deyaaeldeen
pushed a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
May 4, 2021
## What Reverting d79b277 since we are now no longer pinning to 1.3.0. But we still have multiple Identity versions in-flight, so we need the common-versions config ## Why This will resolve https://dev.azure.com/azure-sdk/internal/_build/results?buildId=873579&view=results As per Azure#14909 (comment) we no longer need to prep a v1 update to identity so we can standardize on ^1.1.0 (as there will be no changes in v1 that will force re-recording)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reverting d79b277 since we are now no longer pinning to 1.3.0.
But we still have multiple Identity versions in-flight, so we need the common-versions config
Why
This will resolve https://dev.azure.com/azure-sdk/internal/_build/results?buildId=873579&view=results
As per #14909 (comment) we no longer need to prep a v1 update to identity so we can standardize on ^1.1.0 (as there will be no changes in v1 that will force re-recording)