[Identity] Comment improvements. Identity generally doesn't return null anymore #15783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
scottaddie
requested changes
Jun 17, 2021
sdk/identity/identity/src/credentials/interactiveBrowserCredential.ts
Outdated
Show resolved
Hide resolved
| * client secret details from environment variables. If the expected | ||
| * environment variables are not found at this time, the getToken method | ||
| * will return null when invoked. | ||
| * Creates an instance of the EnvironmentCredential class and reads client secret details from environment variables. |
There was a problem hiding this comment.
Nit: certificates as well as username/password can also be used, maybe they should be mentioned as well (currently it just says "client secret details")?
sdk/identity/identity/src/credentials/interactiveBrowserCredential.browser.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Will Temple <witemple@microsoft.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
sadasant
requested review from
0rland0Wats0n,
ankitarorabit,
bterlson,
chradek,
danieljurek,
deyaaeldeen,
DominikMe,
dw511214992,
ellismg,
EmmaZhu,
HarshaNalluru,
hectorhdzg,
jeremymeng,
jiacfan,
joheredi,
KarishmaGhiya,
LarryOsterman and
ljian3377
as code owners
sadasant
requested review from
praveenkuttappan,
qiaozha,
ramya-rao-a,
richardpark-msft,
sarangan12,
southpolesteve,
vinjiang,
vishnureddy17,
weshaggard,
XiaoningLiu,
xirzec,
YoDaMa,
zfoster and
a team
as code owners
This comment has been minimized.
This comment has been minimized.
sadasant
force-pushed
the
identity/improve-comments
branch
from
909e2f8 to
e1dde79
Compare
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
I had an issue with the git history of this PR, but it should be good now. |
scottaddie
requested changes
Jun 22, 2021
ghost
merged commit
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Aug 26, 2021
updated readme.python.md for Service Bus and Event Hub for 2021-06-01-preview (Azure#15783) Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Aug 26, 2021
updated readme.python.md for Service Bus and Event Hub for 2021-06-01-preview (Azure#15783) Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve got some customers writing to me directly with some confusion regarding getToken returning null. We’ve got some remnants of this type, but at this point, Identity doesn’t return null (except for ClientSecretCredential in the browser, which is generally unusable outside of our tests). This PR is to update these docs and to give a bit of clarity on what errors we’re throwing.