Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synapse] - Ignore known rollup warnings #15948

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

maorleger
Copy link
Member

What

  • Adds warning filter to ignore known rollup warnings that are safe to ignore
  • Ignore this has been rewritten to undefined in synapse
  • Ignore circular dependencies in synapse

Why

These are both known warnings, are safe to ignore, and add noise to the build output unnecessarily.

The first is totally safe to ignore:

var __spreadArray = (this && this.__spreadArray) || function (to, from) {

Is emitted from TypeScript in the OTel ESM and is safe to use.

The second is a known issue in OTel 1.0.0 that is not harmful at runtime.

@maorleger maorleger requested a review from joheredi as a code owner June 24, 2021 15:32
@maorleger maorleger requested a review from xirzec June 24, 2021 15:52
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm okay with this. @chradek does this seem reasonable to you as well?

@maorleger maorleger requested a review from chradek June 25, 2021 17:55
@maorleger maorleger merged commit 5b4eac3 into Azure:main Jun 28, 2021
@maorleger maorleger deleted the rollup-errors branch June 28, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants