Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak workspace settings for VS Code startup perf #15956

Merged
1 commit merged into from
Jun 24, 2021

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Jun 24, 2021

This greatly improved my first open experience on my laptop. The only tradeoff is node_modules folders won't appear in the file tree of VS Code, but I think this is a pretty uncommon place to browse into manually.

rg.exe sometimes goes insane without this.
@xirzec xirzec added the Client This issue points to a problem in the data-plane of the library. label Jun 24, 2021
@xirzec xirzec requested a review from HarshaNalluru June 24, 2021 20:28
@xirzec xirzec self-assigned this Jun 24, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@ghost
Copy link

ghost commented Jun 24, 2021

Hello @xirzec!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@xirzec
Copy link
Member Author

xirzec commented Jun 24, 2021

/check-enforcer reset

@xirzec
Copy link
Member Author

xirzec commented Jun 24, 2021

/check-enforcer evaluate

@xirzec
Copy link
Member Author

xirzec commented Jun 24, 2021

/check-enforcer override

@ghost ghost merged commit aa8db15 into Azure:main Jun 24, 2021
@xirzec xirzec deleted the updateWorkspace branch June 24, 2021 21:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants