Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai-form-recognizer] Added @internal to documentation strings as appropriate. #16181

Merged

Conversation

witemple-msft
Copy link
Member

Closes #13440

@ghost
Copy link

ghost commented Jul 2, 2021

Hello @witemple-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@witemple-msft witemple-msft requested a review from deyaaeldeen July 6, 2021 17:50
Comment on lines +355 to +359
/**
* (INTERNAL) Provides an async iterable of model pages.
*
* @hidden
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not mind having it but it is not needed to tag private members with @hidden. I guess you did this because the locally-generated docs still showed them up? This is a known issue that I need to figure out but docs.microsoft.com does not show untagged private members.

@witemple-msft witemple-msft merged commit d2d7000 into Azure:main Jul 8, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Oct 8, 2021
[Hub Generated] Review request for Microsoft.Logic to add version stable/2019-05-01 (Azure#16181)

* Fixing bugs in Logic Apps swaggers

* Updating example

* Addressed feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form Recognizer] Fix usage of @internal and @hidden tags
2 participants