[ContainerRegistry][Test] Add weekly tests for USGov Cloud and China Cloud #16292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeremymeng
commented
Jul 8, 2021
•
jeremymeng
commented
- Update test resource deployment
- Update test utils to pass authorityHost and authenticationScope
- Update recorder to allow handling different tenant id than default AZURE_TENANT_ID
- Update test resource deployment
jeremymeng
force-pushed
the
acr-cloud-configuration
branch
from
2fed0c5 to
fe7a06d
Compare
annelo-msft
reviewed
Jul 8, 2021
jeremymeng
force-pushed
the
acr-cloud-configuration
branch
from
0716ef1 to
13aa355
Compare
jeremymeng
changed the title
jeremymeng
changed the title
5 tasks
- add missing `.default` permission to scope
jeremymeng
force-pushed
the
acr-cloud-configuration
branch
2 times, most recently
from
cbfdbd7 to
0387864
Compare
as the environment is already the correct one
…t id parameter with a default value of `env.AZURE_TENANT_ID`. As found in ACR weekly-tests pipeline with multi-clouds enabled, AZURE_TENANT_ID and service-specific CONTAINERREGISTRY_TENANT_ID are different so we need to be able to specify which one to handle (while investigating whether it's by-design to have different tenant ids.)
jeremymeng
force-pushed
the
acr-cloud-configuration
branch
3 times, most recently
from
a8b838f to
1bcb455
Compare
|
/azp run js - containerregistry - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HarshaNalluru
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.