[Schema Registry] Apply Archboard requested renames #17720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
conniey,
yunhaoling,
JoshLove-msft and
swathipil
deyaaeldeen
requested review from
bterlson,
chradek and
xirzec
as code owners
| @@ -17,7 +17,7 @@ export interface GetSchemaPropertiesOptions extends OperationOptions { | |||
| } | |||
|
|
|||
| // @public | |||
| export const enum KnownSerializationType { | |||
| export const enum KnownSchemaFormat { | |||
There was a problem hiding this comment.
Why do we use "Known" here?
There was a problem hiding this comment.
It is a standard pattern in JS where we model extensible enums as strings and in their docstring we refer to a known enum that defines the possible values to use. This known enum does not show up anywhere else in the public surface.
JoshLove-msft
approved these changes
Sep 17, 2021
|
I was out when this came in, but just noting that I looked at this now and it looks good to me too. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17697
These renames were requested by the archboard.