[ServiceBus] Use Promise.all() when closing connection context.

[jeremymeng]

so that closing requests are fired immediately.

[jeremymeng]

/azp run js - service-bus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jeremymeng]

In the case of #17932, even the service client's close() is called right after two receivers' subscribe(), the second receiver is able to proceed to further operations like add credits etc. I suspect that because we await each receiver to be close in a loop, the second receiver carries on with its work further while we are in the event loop wait for the first receiver's clean up. This PR changes to use Promise.all() for closing calls so that all the requests are fired immediately.

This does not completely fix the issue that there can still be ongoing activities after close() is called. However it should help with the case in #17932.

Promise.all() will reject on first error, so it almost behavior the same if any error is throw when closing receivers, except that we still have all the other closing requests in flight.

[jeremymeng]

@richardpark-msft thoughts?

[ramya-rao-a]

Why not take this a step further and do a Promise.all() for closing of all the senders, receivers, session receivers etc?

[jeremymeng]

Why not take this a step further and do a Promise.all() for closing of all the senders, receivers, session receivers etc?

I had thought about it, but was afraid of losing the logging for each type of things to close.

[ramya-rao-a]

Those individual log statements for each "type" of entity being closed has not been of much value. We can have a single one at the top. Each link when closing ends up logging anyway internally.

[jeremymeng]

That's fair. I will combine them into one.

[ramya-rao-a]

Can we include the count in paranthesis perhaps? That way we retain that info?

Permanently closing all the senders(4), MessageReceivers(3), MessageSessions(0), and ManagementClients(1)

[jeremymeng]

yes that could be useful.

[jeremymeng]

I just saw that we use Promise.all() for detaching in the same file.

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci