Metrics advisor - identity upgrade to v2 #18588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sadasant
reviewed
Nov 9, 2021
...nistrationclient_datafeed_datafeed/recording_creates_an_azure_application_insights_feed.json
Outdated
Show resolved
Hide resolved
KarishmaGhiya
force-pushed
the
MA-identity
branch
from
286f606 to
bee4201
Compare
jeremymeng
approved these changes
Nov 10, 2021
KarishmaGhiya
force-pushed
the
MA-identity
branch
from
2d36394 to
ab67f02
Compare
KarishmaGhiya
requested review from
deyaaeldeen,
mikeharder,
praveenkuttappan and
witemple-msft
as code owners
KarishmaGhiya
force-pushed
the
MA-identity
branch
from
a9ac7bb to
df837ec
Compare
sadasant
reviewed
Nov 12, 2021
...nistrationclient_datafeed_datafeed/recording_creates_an_azure_application_insights_feed.json
Outdated
Show resolved
Hide resolved
...sadvisoradministrationclient_datafeed_datafeed/recording_creates_an_azure_blob_datafeed.json
Outdated
Show resolved
Hide resolved
sadasant
reviewed
Nov 12, 2021
| @@ -33,7 +33,7 @@ const blobTemplate = "blob_template"; | |||
| const replaceableVariables: { [k: string]: string } = { | |||
| AZURE_CLIENT_ID: "azure_client_id", | |||
| AZURE_CLIENT_SECRET: "azure_client_secret", | |||
| AZURE_TENANT_ID: "azure_tenant_id", | |||
| AZURE_TENANT_ID: "72698866-8641-4147-9144-24744011447", | |||
There was a problem hiding this comment.
oh ok ok, so this is the right tenant. I see.
There was a problem hiding this comment.
The PR description mentions a different tenant 😮
There was a problem hiding this comment.
I can update the PR description - but just curious if we want to keep the same tenant id for recordings across all packages?
There was a problem hiding this comment.
I was mainly confused between the PR description and the PR values.
But if you ask me, I think it would be good to use the same fake tenant as we’ve used before.
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2022
Active Directory connector automatic mode properties (Azure#18588) * Active Directory connector automatic mode properties * fixed capitalization * adding new property to examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR, Identity is upgraded to ^2.0.1 instead of 1.x.x
12345678-1234-1234-1234-123456789012