Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Anomaly Detector December 2021 #19435

Merged
merged 8 commits into from
Jan 13, 2022

Conversation

sarangan12
Copy link
Contributor

@sarangan12 sarangan12 commented Dec 17, 2021

Recently, there has been a SDK Release request (through email) for the Anomaly Detector SDK. According to the request, the new version of the SDK should be generated based on the PR: Azure/azure-rest-api-specs#16543.

This PR is created to satisfy that request.

This PR has some breaking changes. (Some properties have been removed). But, since this SDK is in beta version, I did not update the major version of the package (since breaking changes are allowed in beta versions)

@ramya-rao-a @lmazuel @joheredi Please review and approve the PR

Note:

  1. I have not moved this SDK to the core-client package yet. That involves more changes (thus more time).
  2. The specific version 1.1-preview.1 mentioned in this PR does not seem to exist in Azure yet. I have requested the Service Team (in email) to get ETA for that. Until then, Please do not merge this PR. (Also added the Do Not Merge label)

Verified

This commit was signed with the committer’s verified signature.
@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/ai-anomaly-detector. You can review API changes here

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Do we have an issue tracking the migration from this to corev2?

@sarangan12
Copy link
Contributor Author

sarangan12 commented Dec 17, 2021

  1. Will create one issue for moving it to latest generator
  2. The tests are failing because the specific version 1.1-preview.1 will be deployed only on January 18, 2022. (I have tested locally by changing the version and the tests are passing) I will restart the CI after the service is deployed and then merge this PR. Until then, this PR should not be merged.

moreOver0 and others added 4 commits December 23, 2021 18:14

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
update expected data

Verified

This commit was signed with the committer’s verified signature.
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@sarangan12
Copy link
Contributor Author

/azp run js - anomalydetector - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sarangan12
Copy link
Contributor Author

  1. The service seems to have deployed to production. I have updated the recordings and all the test cases are passing
  2. Confirmed with Laurent that this PR is ready to be merged today
  3. Removing the 'Do Not Merge' label and merging the PR

@sarangan12 sarangan12 merged commit 40e4500 into Azure:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants