Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA release for NetworkTraversal #20038

Merged
merged 5 commits into from
Feb 3, 2022

Conversation

AriZavala2
Copy link
Contributor

Checklists

  • Added impacted package name to the issue description

Packages impacted by this PR:

Issues associated with this PR:

Describe the problem that is addressed by this PR:

What are the possible designs available to address the problem

If there are more than one possible design, why was the one in this PR chosen?

Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)

Are there test cases added in this PR?(If not, why?)

Provide a list of related PRs(if any)

Command used to generate this PR:(Applicable only to SDK release request PRs)

@AriZavala2
Copy link
Contributor Author

Updating Changelog and README in next commit

@AriZavala2 AriZavala2 changed the title Add Autogen code for JS GA release for NetworkTraversal Feb 2, 2022
@AriZavala2 AriZavala2 force-pushed the AriZavala2/changes_for_ga branch from a65e1be to 843b3ba Compare February 3, 2022 07:29
@AriZavala2
Copy link
Contributor Author

/azp run js - communication-network-traversal - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look good (as in, there are none 😄)

@xirzec
Copy link
Member

xirzec commented Feb 3, 2022

@bterlson do we care that this is GAing against core-http so we'll break slightly when it moves to Corev2?

@xirzec
Copy link
Member

xirzec commented Feb 3, 2022

@bterlson do we care that this is GAing against core-http so we'll break slightly when it moves to Corev2?

Confirmed offline, let's handle this in 1.1

@xirzec xirzec merged commit 1a8a7c4 into Azure:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants