-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@azure/search-documents] Change EndPoint in TestResources Json #20058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run js - search-documents - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
approved these changes
Jan 25, 2022
/azp run js - search-documents - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
@sarangan12 Once this approach is proven to work, please check the owners of other cognitive services to ensure we are following the same approach:
|
3 tasks
|
Sounds good, thanks @sarangan12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklists
Packages impacted by this PR:
@azure/search-documents
Issues associated with this PR:
#17577
Describe the problem that is addressed by this PR:
This PR addresses the issue of updating search-documents tests to handle sovereign cloud endpoints dynamically. Earlier, this was done by adding 2 different endpoints (one for US and one for China). Ben has suggested a better approach where we can use just one endpoint and choose the suffix dynamically.
What are the possible designs available to address the problem
No detailed design. This approach is already used in .NET SDK and we are following the same here.
If there are more than one possible design, why was the one in this PR chosen?
N/A
Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)
None
Are there test cases added in this PR?(If not, why?)
This is just updating the Json file and no seperate test cases are required.
Provide a list of related PRs(if any)
#19781
Command used to generate this PR:(Applicable only to SDK release request PRs)
N/A
@benbp Please review and approve the PR.