[KeyVault] Fix keyvault-admin live tests #22447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timovv
requested review from
deyaaeldeen,
HarshaNalluru,
jeremymeng,
joheredi and
xirzec
|
API change check API changes are not detected in this pull request. |
jeremymeng
approved these changes
Jul 5, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Feb 8, 2023
moving preview version to public folder (Azure#22447) * moving preview version to public folder * updating cadl file * fixing cadl compile error * fixing inconsistent cadl --------- Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/keyvault-adminIssues associated with this PR
Describe the problem that is addressed by this PR
We're seeing some different behavior from the service causing it to fail sooner than previously when a bad SAS token is passed in two error-handling tests. This PR updates the tests so that they align with the new behavior.