Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Search, Route, Render test #22566

Closed
wants to merge 129 commits into from
Closed

Conversation

dubiety
Copy link
Member

@dubiety dubiety commented Jul 13, 2022

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@dubiety
Copy link
Member Author

dubiety commented Jul 13, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety dubiety force-pushed the charlie/ci-pipeline branch from 5bd325a to 57930dc Compare July 18, 2022 10:16
@dubiety
Copy link
Member Author

dubiety commented Jul 18, 2022

/azp run js - maps - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety dubiety force-pushed the charlie/ci-pipeline branch 2 times, most recently from 17651d8 to 59b16ee Compare July 19, 2022 08:14
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@dubiety
Copy link
Member Author

dubiety commented Jul 21, 2022

/azp run js - maps - c

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dubiety
Copy link
Member Author

dubiety commented Jul 21, 2022

/azp run js - maps - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety dubiety force-pushed the charlie/ci-pipeline branch from 8dbeb3b to d0dcf65 Compare July 21, 2022 05:59
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/check-enforcer override

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps-search - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps-render - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps-render - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps-render - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 28, 2022

/azp run js - maps-render - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 29, 2022

/azp run js - maps-route - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Jul 29, 2022

/azp run js - maps-search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Hi @dubiety. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@dubiety dubiety closed this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants