[identity] Partially revert #19356 #22808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witemple-msft
requested review from
praveenkuttappan and
deyaaeldeen
as code owners
witemple-msft
requested review from
jeremymeng,
KarishmaGhiya and
schaabs
as code owners
xirzec
approved these changes
Aug 4, 2022
|
API change check API changes are not detected in this pull request. |
KarishmaGhiya
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a transitive dependency on github.com/samuelkubai/node-bindings from the repo.
An NPM bug (npm/cli#4896) causes github package references to hang on Linux hosts because it attempts to use the unsupported git protocol.
This causes a two minute delay when running rush update from linux hosts, including our pipeline agents. Furthermore, github-based dependencies are altogether risky, since they can naturally subvert versioning constraints, so we will be blocked from upgrading msal-node-extensions until we can upgrade to a version that does not have this behavior.
Fortunately, we never shipped a dependency on msal-node-extensions 13, so this downgrade shouldn't require a release.
CC @mikeharder @xirzec