-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Enable OcrSkill and ImageAnalysisSkill #23495
[Search] Enable OcrSkill and ImageAnalysisSkill #23495
Conversation
Regenerate RLC
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this PR to be mostly adding some new skill config, but it looks like we're doing rather broad property renames?
… search/enable-ocrskill-and-imageanalysisskill
0058207
to
0082b2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch about the transform issue!
I think this PR is pretty much good to merge, just some housekeeping with mentioning the breaking change of the odatatype
@@ -247,7 +247,7 @@ directive: | |||
```yaml | |||
directive: | |||
- from: swagger-document | |||
where: $.definitions..properties["@odata.etag"] | |||
where: $.definitions..properties["`@odata.etag"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL that backtick is the escape character for swagger transforms and that @
is apparently reserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not specified in the OpenAPI or JSONPath specs, but in the docs for jsonpath-plus
, the library which Autorest depends on. Isn't that cool and easy to find?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update 2023-03-01 to sync with RPSaaSMaster (Azure#23495) * Adds base for updating Microsoft.AzureStackHCI from version stable/2023-02-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Consent and Disable APIs added * add managed by for extensions * prettier fix * Update cluster resource json
(Purportedly) fixes #23263