[core] Core updates for Storage migration #24356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
requested review from
ckairen,
witemple-msft,
deyaaeldeen,
jeremymeng and
bterlson
as code owners
ghost
added
the
xirzec
added
the
Client
jeremymeng
approved these changes
Jan 3, 2023
| @@ -112,11 +112,3 @@ export async function parseXML(str: string, opts: XmlOptions = {}): Promise<any> | |||
|
|
|||
| return parsedXml; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Just pushed some CHANGELOG updates :)
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
Merging this since @witemple-msft also took a look when it was part of the other PR. |
|
Somehow this PR broke app-config CI: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2089188&view=logs&j=b90ae18a-ab13-53d3-1df4-bcba2aec1a70&t=ac4fb594-9cc2-50fc-bf40-ff99f9e7d5ba&l=297 All the changes look innocent to me. |
|
oh appconfig uses core-http-compat too, maybe some changes there isn't working well with nock? |
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Jan 18, 2023
The xml parsing test started failing after core-xml changes in PR Azure#24356. This PR applies test fix similar to what's been done to core-xml tests in PR Azure#24356.
jeremymeng
added a commit
that referenced
this pull request
Jan 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
core-client
core-http-compat
core-rest-pipeline
core-xml
Issues associated with this PR
#24141
Describe the problem that is addressed by this PR
Supporting changes needed in order to migrate Storage SDKs.
One critical performance fix in core-rest-pipeline with HEAD requests, otherwise mostly enhancements to core-http-compat including
clonesupport.