Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@Azure/eventgrid] Adding new events for EG Version 4.14.0 #26939

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

sarangan12
Copy link
Contributor

@sarangan12 sarangan12 commented Aug 25, 2023

Packages impacted by this PR

@azure/eventgrid

API View To Approve

https://apiview.dev/Assemblies/Review/5d8f03952cfd409992e7ab62d145090d/f9a84720b15e461b988d7405a7538577?diffRevisionId=8c1f850364cb4018a1e65c579d6aded5&doc=False&diffOnly=True

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

The EventGrid Service Team has added 5 new events. The SDK must be regenerated to include the code changes related to these 6 new events. The SDK minor version has been updated.

  • EventGridMqttClientCreatedOrUpdatedEventData
  • EventGridMqttClientDeletedEventData
  • EventGridMqttClientSessionConnectedEventData
  • EventGridMqttClientSessionDisconnectedEventData,
  • AppConfigurationSnapshotCreatedEventData,
  • AppConfigurationSnapshotModifiedEventData,

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

There are no specific/complex design scenarios for this task. It is a straightforward regenerate and some standard changes to the custom layer of the code.

Are there test cases added in this PR? (If not, why?)

No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient.

Provide a list of related PRs (if any)

#26020 (This is the PR that adds similar events to the SDK in the 4.13.0 release)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

autorest --typescript swagger\README.md

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@xirzec @ellismg @jeremymeng Please review and approve the PR.

@lmazuel FYI

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-eventgrid

@sarangan12 sarangan12 changed the title Adding new events for EG Version 4.14.0 [@Azure/eventgrid] Adding new events for EG Version 4.14.0 Aug 25, 2023
@sarangan12 sarangan12 marked this pull request as ready for review August 25, 2023 17:14

// @public
export const enum KnownEventGridMqttClientState {
// (undocumented)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ref-docs for this?

// (undocumented)
Disabled = "Disabled",
// (undocumented)
Enabled = "Enabled"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ref-docs?

@sarangan12
Copy link
Contributor Author

/check-enforcer evaluate

@sarangan12
Copy link
Contributor Author

/check-enforcer override

@sarangan12 sarangan12 merged commit da0ddb9 into Azure:main Sep 14, 2023
sarangan12 added a commit that referenced this pull request Oct 12, 2023
### Packages impacted by this PR

@azure/eventgrid

**API View To Approve** 

https://apiview.dev/Assemblies/Review/5e90bd4451cb46cc9821566d47def654/cce942767eb24bc4b4cbfb208da4e36b?diffRevisionId=9724b1f196ed47dd9e89b0bd48dd8ea7&doc=False&diffOnly=True

### Issues associated with this PR

NA

### Describe the problem that is addressed by this PR

The EventGrid Service Team has added 23 new events. The SDK must be
regenerated to include the code changes related to these 23 new events.
The SDK minor version has been updated.

-
`Microsoft.ResourceNotifications.HealthResources.AvailabilityStatusChanged`
  - `Microsoft.ResourceNotifications.HealthResources.ResourceAnnotated`
  - `Microsoft.Communication.RouterWorkerDeregistered`
  - `Microsoft.Communication.RouterWorkerRegistered`
  - `Microsoft.Communication.RouterJobCancelled`
  - `Microsoft.Communication.RouterJobClassificationFailed`
  - `Microsoft.Communication.RouterJobClassified`
  - `Microsoft.Communication.RouterJobClosed`
  - `Microsoft.Communication.RouterJobCompleted`
  - `Microsoft.Communication.RouterJobDeleted`
  - `Microsoft.Communication.RouterJobExceptionTriggered`
  - `Microsoft.Communication.RouterJobQueued`
  - `Microsoft.Communication.RouterJobReceived`
  - `Microsoft.Communication.RouterJobSchedulingFailed`
  - `Microsoft.Communication.RouterJobUnassigned`
  - `Microsoft.Communication.RouterJobWaitingForActivation`
  - `Microsoft.Communication.RouterJobWorkerSelectorsExpire`
  - `Microsoft.Communication.RouterWorkerDeleted`
  - `Microsoft.Communication.RouterWorkerOfferAccepted`
  - `Microsoft.Communication.RouterWorkerOfferDeclined`
  - `Microsoft.Communication.RouterWorkerOfferExpired`
  - `Microsoft.Communication.RouterWorkerOfferIssued`
  - `Microsoft.Communication.RouterWorkerOfferRevoked`

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_

- #26939 (This is the PR
that adds similar events to the SDK in the 4.14.0 release)
- #26020 (This is the PR
that adds similar events to the SDK in the 4.13.0 release)

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

`autorest --typescript swagger\README.md`

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
sarangan12 added a commit that referenced this pull request Nov 10, 2023
### Packages impacted by this PR
@azure/eventgrid

**API View To Approve** 

https://apiview.dev/Assemblies/Review/30d6488f3dd647a79d175e408d5d5303?diffRevisionId=20bf158c9f2341eba08c706d55a0aa4c&diffOnly=False&revisionId=f5dd29153bf946c0aa1d47886fcd5eaf&doc=true

### Issues associated with this PR

NA

### Describe the problem that is addressed by this PR

The EventGrid Service Team has added 2 new events. The SDK must be
regenerated to include the code changes related to these 2 new events.
The SDK minor version has been updated.

- `Microsoft.ResourceNotifications.Resources.CreatedOrUpdated`
- `Microsoft.ResourceNotifications.Resources.Deleted`


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

One of the important issues to note down is that this release does have
a breaking change. The data type of `tags` property has been changed
from `string` to object. So, this is a breaking change. Accordingly, the
major version has been updated.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_

- #27384 (This is the PR
that adds similar events to the SDK in the 4.15.0 release)
- #26939 (This is the PR
that adds similar events to the SDK in the 4.14.0 release)
- #26020 (This is the PR
that adds similar events to the SDK in the 4.13.0 release)

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

`autorest --typescript swagger\README.md`

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)

@xirzec Please review and approve the PR and API View. Thanks
sarangan12 added a commit that referenced this pull request Jan 9, 2024
### Packages impacted by this PR

@azure/eventgrid

### Issues associated with this PR

NA

### Describe the problem that is addressed by this PR

The EventGrid Service Team has added 2 new events. The SDK must be
regenerated to include the code changes related to these 2 new events.
The SDK minor version has been updated.

  - `Microsoft.Storage.StorageTaskAssignmentQueued`
  - `Microsoft.Storage.StorageTaskAssignmentCompleted`
 
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_

- #27384 (This is the PR
that adds similar events to the SDK in the 4.15.0 release)
- #26939 (This is the PR
that adds similar events to the SDK in the 4.14.0 release)
- #26020 (This is the PR
that adds similar events to the SDK in the 4.13.0 release)


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

`autorest --typescript swagger\README.md`

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
sarangan12 added a commit that referenced this pull request Feb 8, 2024
### Packages impacted by this PR

@azure/eventgrid

### Issues associated with this PR

NA

### Describe the problem that is addressed by this PR

The EventGrid Service Team has added 14 new events. The SDK must be
regenerated to include the code changes related to these 14 new events.
The SDK minor version has been updated.

  - `Microsoft.Storage.StorageTaskAssignmentQueued`
  - `Microsoft.Storage.StorageTaskAssignmentCompleted`
  - `Microsoft.AVS.ScriptExecutionStarted`
  - `Microsoft.AVS.ScriptExecutionFinished`
  - `Microsoft.AVS.ScriptExecutionCancelled`
  - `Microsoft.AVS.ScriptExecutionFailed`
  - `Microsoft.AVS.PrivateCloudUpdating`
  - `Microsoft.AVS.PrivateCloudUpdated`
  - `Microsoft.AVS.PrivateCloudFailed`
  - `Microsoft.AVS.ClusterCreated`
  - `Microsoft.AVS.ClusterDeleted`
  - `Microsoft.AVS.ClusterUpdating`
  - `Microsoft.AVS.ClusterUpdated`
  - `Microsoft.AVS.ClusterFailed`
 
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_

- #27384 (This is the PR
that adds similar events to the SDK in the 4.15.0 release)
- #26939 (This is the PR
that adds similar events to the SDK in the 4.14.0 release)
- #26020 (This is the PR
that adds similar events to the SDK in the 4.13.0 release)
- #28176 (This is the PR
that adds similar events to the SDK in the 5.1.0 release)


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

`autorest --typescript swagger\README.md`

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
sarangan12 added a commit that referenced this pull request Mar 13, 2024
### Packages impacted by this PR

@azure/eventgrid

### Issues associated with this PR

NA

### Describe the problem that is addressed by this PR

The EventGrid Service Team has added 2 new events. The SDK must be
regenerated to include the code changes related to these 2 new events.
The SDK minor version has been updated.

  - `Microsoft.ApiCenter.ApiDefinitionAdded`
  - `Microsoft.ApiCenter.ApiDefinitionUpdated`

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_

- #27384 (This is the PR
that adds similar events to the SDK in the 4.15.0 release)
- #26939 (This is the PR
that adds similar events to the SDK in the 4.14.0 release)
- #26020 (This is the PR
that adds similar events to the SDK in the 4.13.0 release)
- #28176 (This is the PR
that adds similar events to the SDK in the 5.1.0 release)
- #28513 (This is the PR
that adds similar events to the SDK in the 5.2.0 release)

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

`autorest --typescript swagger\README.md`

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
sarangan12 added a commit that referenced this pull request Apr 10, 2024
### Packages impacted by this PR

@azure/eventgrid

### Issues associated with this PR

NA

### Describe the problem that is addressed by this PR

The EventGrid Service Team has added 3 new events. The SDK must be
regenerated to include the code changes related to these 3 new events.
The SDK minor version has been updated.

  - `Microsoft.Communication.AdvancedMessageDeliveryStatusUpdated`
  - `Microsoft.Communication.AdvancedMessageReceived`
  - `Microsoft.Communication.RouterWorkerUpdated`
  
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_
- #27384 (This is the PR
that adds similar events to the SDK in the 4.15.0 release)
- #26939 (This is the PR
that adds similar events to the SDK in the 4.14.0 release)
- #26020 (This is the PR
that adds similar events to the SDK in the 4.13.0 release)
- #28176 (This is the PR
that adds similar events to the SDK in the 5.1.0 release)
- #28513 (This is the PR
that adds similar events to the SDK in the 5.2.0 release)
- #28891 (This is the PR
that adds similar events to the SDK in the 5.3.0 release)

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

`autorest --typescript swagger\README.md`

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants