Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor-Opentelemetry-Exporter] Metric and Span Util Tests #27229

Merged
merged 7 commits into from
Sep 28, 2023
Merged

[Monitor-Opentelemetry-Exporter] Metric and Span Util Tests #27229

merged 7 commits into from
Sep 28, 2023

Conversation

JacksonWeber
Copy link
Member

@JacksonWeber JacksonWeber commented Sep 25, 2023 •
edited
Loading

Packages impacted by this PR

@azure/monitor-opentelemetry-exporter

Describe the problem that is addressed by this PR

Adds tests to the metricUtils, spanUtils, and fileSystemPersister classes.

Checklists

  • Added impacted package name to the issue description
  • Added a changelog (if necessary)

@JacksonWeber JacksonWeber changed the title Metric and Span Util Tests [Monitor-Opentelemetry-Exporter] Metric and Span Util Tests Sep 25, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

hectorhdzg
hectorhdzg approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit 9539cb6 into Azure:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacksonWeber @azure-sdk @hectorhdzg