[core-util] Fix issue with Deno showing up as isNode at runtime. #27459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
added
the
Client
2 tasks
mpodwysocki
approved these changes
Oct 18, 2023
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-utilIssues associated with this PR
Fixes #27077
Describe the problem that is addressed by this PR
Deno implemented
process.versions.node, which is how we detect that we are running inside a Node environment. Since Deno actually is much closer to a browser environment, this is not what was expected at runtime and resulted in things like loading the browser version of pipeline policies that throw due to not being implemented/relevant in browsers.I kept this really simple by making
isNodecheck thatisDenois false. SinceisNodewas previously false inside Deno environments, I don't think this will break anything.Provide a list of related PRs (if any)
#27090